Re: [PATCH 4/5] xfs: simplify the fallocate path

xfs

Re: [PATCH 4/5] xfs: simplify the fallocate path

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/5] xfs: simplify the fallocate path
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 10 Dec 2012 05:52:12 -0500
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<20121210020956.GN15784@dastard>
References:	<20121208120812.755863148@xxxxxxxxxxxxxxxxxxxxxx> <20121208121006.286014845@xxxxxxxxxxxxxxxxxxxxxx> <20121210020956.GN15784@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Dec 10, 2012 at 01:09:56PM +1100, Dave Chinner wrote:
> You don't use this flag anywhere ;)

Fixed.

> While I like most of this series, I don't really like the
> duplication of this piece of code. It seems to me that a simple
> helper like:

I had that in a previous version, but it seemed uglier than just
opencoding it.  I'll give it another try, maybe I can come up
with something nicer now.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/5] refactor the preallocation and hole punching code, Christoph Hellwig [PATCH 1/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag, Christoph Hellwig [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size, Christoph Hellwig [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space, Christoph Hellwig [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space, Christoph Hellwig [PATCH 4/5] xfs: simplify the fallocate path, Christoph Hellwig Re: [PATCH 4/5] xfs: simplify the fallocate path, Dave Chinner Re: [PATCH 4/5] xfs: simplify the fallocate path, Christoph Hellwig <=

Previous by Date:	Re: XFS write cache flush policy, Matthias Schniedermeyer
Next by Date:	Warning Your mailbox is over its size limit, Larie Hucke
Previous by Thread:	Re: [PATCH 4/5] xfs: simplify the fallocate path, Dave Chinner
Next by Thread:	[PATCH] xfsprogs: document fpunch command in xfs_io, Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]