xfs
[Top] [All Lists]

Re: [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidi

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: Ensure cmdline geometry puts mkfs.xfs into multidisk mode
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sat, 08 Dec 2012 10:27:47 -0600
Cc: Ben England <bengland@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20121208120007.GB4430@xxxxxxxxxxxxx>
References: <50ABB115.9070905@xxxxxxxxxxx> <20121121095636.GC23339@xxxxxxxxxxxxx> <50C115E8.9090106@xxxxxxxxxxx> <20121208120007.GB4430@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/17.0 Thunderbird/17.0
On 12/8/12 6:00 AM, Christoph Hellwig wrote:
> On Thu, Dec 06, 2012 at 04:02:16PM -0600, Eric Sandeen wrote:
>> Ensure that when mkfs.xfs is invoked with commandline geometry, it
>> triggers multidisk mode and creates more AGs.
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks

>> Maybe this should also test device-specified geometry, but not sure
>> how to do that easily within xfstests, any ideas?
> 
> That would involved scsi_debug so that we could set them up.  We had
> several ideas how to use scsi debug for these sort of tests but never
> really bothered to do it.  If you have some spare cycles I'd love to see
> this sort of tests.

scsi_debug won't report geometry on its own today; we'd need to assemble
something out of scsi_debug luns I'm afraid, so it gets even more involved.

We do have a little bit of scsi_debug framework in xfstests today, though,
so if scsi_debug grew the capability it'd be easy to add.

-Eric


<Prev in Thread] Current Thread [Next in Thread>