xfs
[Top] [All Lists]

Re: [PATCH v3 1/5] xfs: use b_maps[] for discontiguous buffers

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v3 1/5] xfs: use b_maps[] for discontiguous buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 8 Dec 2012 07:23:35 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121204224938.599314438@xxxxxxx>
References: <20121204231801.982422341@xxxxxxx> <20121204224938.599314438@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Dec 04, 2012 at 05:18:02PM -0600, Mark Tinguely wrote:
> Commits starting at 77c1a08 introduced a multiple segment support
> to xfs_buf. xfs_trans_buf_item_match() could not find a multi-segment
> buffer in the transaction because it was looking at the single segment
> block number rather than the multi-segment b_maps[0].bm.bn. This
> results on a recursive buffer lock that can never be satisfied.
> 
> This patch:
>  1) Changed the remaining b_map accesses to be b_maps[0] accesses.
>  2) Renames the single segment b_map structure to __b_map to avoid
>     future confusion.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>