xfs
[Top] [All Lists]

Re: [PATCH v2 3/3] xfs: fix the multi-segment log buffer format

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH v2 3/3] xfs: fix the multi-segment log buffer format
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Dec 2012 10:52:11 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121128222622.908368793@xxxxxxx>
References: <20121128222309.109033307@.sgi.com> <20121128222622.908368793@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 28, 2012 at 04:23:12PM -0600, Mark Tinguely wrote:
> Per Dave Chinner suggestion, this patch:
>  1) Corrects the detection of whether a multi-segment buffer is
>     still tracking data.
>  2) Clears all the buffer log formats for a multi-segment buffer.
> 
> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx>
> 
> ---
>  fs/xfs/xfs_buf_item.c  |   13 ++++++++++---
>  fs/xfs/xfs_trans_buf.c |    7 +++++--
>  2 files changed, 15 insertions(+), 5 deletions(-)
> 
> Index: b/fs/xfs/xfs_buf_item.c
> ===================================================================
> --- a/fs/xfs/xfs_buf_item.c
> +++ b/fs/xfs/xfs_buf_item.c
> @@ -508,7 +508,7 @@ xfs_buf_item_unlock(
>  {
>       struct xfs_buf_log_item *bip = BUF_ITEM(lip);
>       struct xfs_buf          *bp = bip->bli_buf;
> -     int                     aborted;
> +     int                     aborted, empty, i;
>       uint                    hold;
>  
>       /* Clear the buffer's association with this transaction. */
> @@ -551,8 +551,15 @@ xfs_buf_item_unlock(
>        * If the buf item isn't tracking any data, free it, otherwise drop the
>        * reference we hold to it.
>        */
> -     if (xfs_bitmap_empty(bip->__bli_format.blf_data_map,
> -                          bip->__bli_format.blf_map_size))
> +     empty = 1;
> +     for (i = 0; i < bip->bli_format_count; i++) {
> +             if (!xfs_bitmap_empty(bip->bli_formats[i].blf_data_map,
> +                          bip->bli_formats[i].blf_map_size)) {
> +                     empty = 0;
> +                     break;
> +             }
> +     }
> +     if (empty)
>               xfs_buf_item_relse(bp);
>       else
>               atomic_dec(&bip->bli_refcount);

I think "clean" is a better name for the temporary variable, as what
we are actually checking is whether the buffer has been modified or
not (i.e. whether it is clean or dirty)....

> Index: b/fs/xfs/xfs_trans_buf.c
> ===================================================================
> --- a/fs/xfs/xfs_trans_buf.c
> +++ b/fs/xfs/xfs_trans_buf.c
> @@ -643,6 +643,7 @@ xfs_trans_binval(
>       xfs_buf_t       *bp)
>  {
>       xfs_buf_log_item_t      *bip = bp->b_fspriv;
> +     int                     i;
>  
>       ASSERT(bp->b_transp == tp);
>       ASSERT(bip != NULL);
> @@ -670,8 +671,10 @@ xfs_trans_binval(
>       bip->bli_flags &= ~(XFS_BLI_INODE_BUF | XFS_BLI_LOGGED | XFS_BLI_DIRTY);
>       bip->__bli_format.blf_flags &= ~XFS_BLF_INODE_BUF;
>       bip->__bli_format.blf_flags |= XFS_BLF_CANCEL;
> -     memset((char *)(bip->__bli_format.blf_data_map), 0,
> -           (bip->__bli_format.blf_map_size * sizeof(uint)));
> +     for (i = 0; i < bip->bli_format_count; i++) {
> +             memset((char *)(bip->bli_formats[i].blf_data_map), 0,
> +                    (bip->bli_formats[i].blf_map_size * sizeof(uint)));

No cast needed - memset() takes a void pointer....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2 3/3] xfs: fix the multi-segment log buffer format, Dave Chinner <=