xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfs: byte range granularity for XFS_IOC_ZERO_RANGE

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfs: byte range granularity for XFS_IOC_ZERO_RANGE
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 28 Nov 2012 08:33:05 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1354068063-1692-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1354068063-1692-1-git-send-email-david@xxxxxxxxxxxxx> <1354068063-1692-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 28, 2012 at 01:01:01PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> XFS_IOC_ZERO_RANGE simply does not work properly for non page cache
> aligned ranges. Neither test 242 or 290 exercise this correctly, so
> the behaviour is completely busted even though the tests pass.
> 
> Fix it to support full byte range granularity as was originally
> intended for this ioctl.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Look good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>