xfs
[Top] [All Lists]

Re: [PATCH 4/4] xfs: fix sparse reported log CRC endian issue

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: fix sparse reported log CRC endian issue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 28 Nov 2012 08:30:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1354068063-1692-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1354068063-1692-1-git-send-email-david@xxxxxxxxxxxxx> <1354068063-1692-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 28, 2012 at 01:01:03PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Not a bug as such, just warning noise from the xlog_cksum()
> returning a __be32 type when it shoul dbe returning a __le32 type.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

The patch look okay.

But why are we storing the crc field little endian while all other on
disk formats are big endian? (And yes I realize it might as well have
been me who did that back in the idea, but I still have no idea why)

<Prev in Thread] Current Thread [Next in Thread>