xfs
[Top] [All Lists]

Re: [xfs:for-next 72/74] fs/xfs/xfs_log.c:1709:32: sparse: incorrect typ

To: kbuild test robot <fengguang.wu@xxxxxxxxx>
Subject: Re: [xfs:for-next 72/74] fs/xfs/xfs_log.c:1709:32: sparse: incorrect type in assignment (different base types)
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 28 Nov 2012 12:00:05 +1100
Cc: Christoph Hellwig <hch@xxxxxx>, Ben Myers <bpm@xxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <50b45f45.SLR36oqX9vHupAe2%fengguang.wu@xxxxxxxxx>
References: <50b45f45.SLR36oqX9vHupAe2%fengguang.wu@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Nov 27, 2012 at 02:35:49PM +0800, kbuild test robot wrote:
> tree:   git://oss.sgi.com/xfs/xfs for-next
> head:   7c4cebe8e02dd0b0e655605442bbe9268db9ed4f
> commit: 0e446be44806240c779666591bb9e8cb0e86a50d [72/74] xfs: add CRC checks 
> to the log
> 
> 
> sparse warnings:
> 
> + fs/xfs/xfs_log.c:1709:32: sparse: incorrect type in assignment (different 
> base types)
> fs/xfs/xfs_log.c:1709:32:    expected restricted __le32 [usertype] h_crc
> fs/xfs/xfs_log.c:1709:32:    got restricted __be32
> + fs/xfs/xfs_log.c:1568:29: sparse: incorrect type in return expression 
> (different base types)
> fs/xfs/xfs_log.c:1568:29:    expected restricted __be32
> fs/xfs/xfs_log.c:1568:29:    got restricted __le32
> fs/xfs/xfs_log.c:267:17: sparse: context imbalance in 'xlog_grant_head_wait' 
> - unexpected unlock
> --
> + fs/xfs/xfs_log_recover.c:3239:13: sparse: restricted __be32 degrades to 
> integer
> + fs/xfs/xfs_log_recover.c:3239:25: sparse: restricted __le32 degrades to 
> integer
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast to restricted __be32
> + fs/xfs/xfs_log_recover.c:3243:41: sparse: cast from restricted __le32

Hmmm, why wasn't my sparse runs picking this up?

/me upgrades sparse from current git

Oh, look, they show up now. I'll get them fixed.

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>