xfs
[Top] [All Lists]

Re: [RFC] [PATCH] xfs_quota: support relative path as `path' arguments

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>, xfs ML <xfs@xxxxxxxxxxx>
Subject: Re: [RFC] [PATCH] xfs_quota: support relative path as `path' arguments
From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
Date: Wed, 28 Nov 2012 08:41:39 +0900
In-reply-to: <20121127165001.GA11620@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <50B49074.1020000@xxxxxxxxxxxxxx> <20121127165001.GA11620@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 6.0; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
Hi Carlos,

(2012/11/28 1:50), Carlos Maiolino wrote:
> On Tue, Nov 27, 2012 at 07:05:40PM +0900, Satoru Takeuchi wrote:
> 
>> From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
>>
>> Current xfs_quota only accepts absolute path as its `path' arguments.
>> This patch adds the support of relative path for user's convenience.
>>
>> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
>>
> 
> Using realpath() to handle the path being passed by user, not only makes able
> the usage of relative paths, but also fixes the problem in having a "/" at the
> end of the path. For those who abuses of TABs, this is very annoying.

Ah, I also tend to fix the trailing "/" at the end of the path as you said.
But I forgot to mentioned about it by the patch description :-)

Thanks,
Satoru

> 
> Looks good,
> 
> Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> 
> Tested-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> 
>> ---
>>  libxcmd/paths.c |   42 +++++++++++++++++++++++++++++-------------
>>  1 file changed, 29 insertions(+), 13 deletions(-)
>>
>> diff --git a/libxcmd/paths.c b/libxcmd/paths.c
>> index 2a92299..bd84cde 100644
>> --- a/libxcmd/paths.c
>> +++ b/libxcmd/paths.c
>> @@ -27,6 +27,7 @@
>>  #include <xfs/path.h>
>>  #include <xfs/input.h>
>>  #include <xfs/project.h>
>> +#include <limits.h>
>>  
>>  extern char *progname;
>>  
>> xfs mailing list
>> xfs@xxxxxxxxxxx
>> http://oss.sgi.com/mailman/listinfo/xfs
> 


<Prev in Thread] Current Thread [Next in Thread>