On Tue, Nov 27, 2012 at 07:05:40PM +0900, Satoru Takeuchi wrote:
> From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
>
> Current xfs_quota only accepts absolute path as its `path' arguments.
> This patch adds the support of relative path for user's convenience.
>
> Signed-off-by: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
>
Using realpath() to handle the path being passed by user, not only makes able
the usage of relative paths, but also fixes the problem in having a "/" at the
end of the path. For those who abuses of TABs, this is very annoying.
Looks good,
Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Tested-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
> libxcmd/paths.c | 42 +++++++++++++++++++++++++++++-------------
> 1 file changed, 29 insertions(+), 13 deletions(-)
>
> diff --git a/libxcmd/paths.c b/libxcmd/paths.c
> index 2a92299..bd84cde 100644
> --- a/libxcmd/paths.c
> +++ b/libxcmd/paths.c
> @@ -27,6 +27,7 @@
> #include <xfs/path.h>
> #include <xfs/input.h>
> #include <xfs/project.h>
> +#include <limits.h>
>
> extern char *progname;
>
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
|