On Fri, Nov 23, 2012 at 07:41:19AM -0500, Christoph Hellwig wrote:
> On Mon, Nov 12, 2012 at 10:54:00PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > For verification purposes, AGFLs need to be initialised to a known
> > set of values. For upcoming CRC changes, they are also headers that
> > need to be initialised. Currently, growfs does neither for the AGFLs
> > - it ignores them completely. Add initialisation of the AGFL to be
> > full of invalid block numbers (NULLAGBLOCK) to put the
> > infrastructure in place needed for CRC support.
> > Includes a comment clarification from Jeff Liu.
> Looks good.
> If you plan to touch this code even more I'd suggst splitting out a
> helper for each kinda of block / header that is initialized from
I thought about doing that, but in the end I wanted to avoid
structural changes as much as possible. As it is, I do need to touch
bits of it for the CRC code - refactoring it will involve rebasing
several patches though... :/