xfs
[Top] [All Lists]

Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/32] xfs: make growfs initialise the AGFL header
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2012 07:41:19 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352721264-3700-9-git-send-email-david@xxxxxxxxxxxxx>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 12, 2012 at 10:54:00PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> For verification purposes, AGFLs need to be initialised to a known
> set of values. For upcoming CRC changes, they are also headers that
> need to be initialised. Currently, growfs does neither for the AGFLs
> - it ignores them completely. Add initialisation of the AGFL to be
> full of invalid block numbers (NULLAGBLOCK) to put the
> infrastructure in place needed for CRC support.
> 
> Includes a comment clarification from Jeff Liu.

Looks good.

If you plan to touch this code even more I'd suggst splitting out a
helper for each kinda of block / header that is initialized from
xfs_growfs_data_private.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>