xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix to build src/realpath and the correct the exis

To: rjohnston@xxxxxxx
Subject: Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2012 07:37:40 -0500
Cc: xfs@xxxxxxxxxxx, Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>
In-reply-to: <20121121135210.840563563@xxxxxxx>
References: <20121121135123.092349449@xxxxxxx> <20121121135210.840563563@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 21, 2012 at 07:51:24AM -0600, rjohnston@xxxxxxx wrote:
> From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
> 
> Commit d5ea873f is not the same as the the following original Eric's patch.
> 
> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
> 
> It does not modify src/Makefile and realpath is never compiled.
> 
> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
> if $TEST_DEV or $SCRATCH_DEV are not defined.
> 
> Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>
> Cc: Rich Johnston <rjohnston@xxxxxxx>

Thanks for the fixes, this looks good.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>