xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: fix the buffer log format for contiguous buffers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: fix the buffer log format for contiguous buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2012 02:37:09 -0500
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121123014714.GB32450@dastard>
References: <20121120224120.224166649@xxxxxxx> <20121120224146.479983109@xxxxxxx> <20121123014714.GB32450@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 23, 2012 at 12:47:14PM +1100, Dave Chinner wrote:
> This debug code is a lot more broken than just this. It's completely
> unaware of discontiguous buffers....
> 
> I'm wondering if we should just remove the XFS_TRANS_DEBUG code
> because it doesn't ever get used....

As far as I know it has been unused since I started working on XFS,
so removing it sounds fine to me.

<Prev in Thread] Current Thread [Next in Thread>