xfs
[Top] [All Lists]

Re: [PATCH 7/9] ocfs2: Use generic handlers of O_SYNC AIO DIO

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: [PATCH 7/9] ocfs2: Use generic handlers of O_SYNC AIO DIO
From: Joel Becker <jlbec@xxxxxxxxxxxx>
Date: Wed, 21 Nov 2012 11:32:41 -0800
Cc: axboe@xxxxxxxxx, tytso@xxxxxxx, david@xxxxxxxxxxxxx, jmoyer@xxxxxxxxxx, bpm@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20121120075114.25270.83181.stgit@xxxxxxxxxxxxxxxxxxx>
Mail-followup-to: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, axboe@xxxxxxxxx, tytso@xxxxxxx, david@xxxxxxxxxxxxx, jmoyer@xxxxxxxxxx, bpm@xxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20121120074116.24645.36369.stgit@xxxxxxxxxxxxxxxxxxx> <20121120075114.25270.83181.stgit@xxxxxxxxxxxxxxxxxxx>
Sender: Joel Becker <jlbec@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 19, 2012 at 11:51:14PM -0800, Darrick J. Wong wrote:
> Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC
> file.
> 
> From: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> Signed-off-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
Acked-by: Joel Becker <jlbec@xxxxxxxxxxxx>

> ---
>  fs/ocfs2/aops.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> 
> diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
> index 6577432..60457cc 100644
> --- a/fs/ocfs2/aops.c
> +++ b/fs/ocfs2/aops.c
> @@ -593,9 +593,7 @@ static void ocfs2_dio_end_io(struct kiocb *iocb,
>       level = ocfs2_iocb_rw_locked_level(iocb);
>       ocfs2_rw_unlock(inode, level);
>  
> -     if (is_async)
> -             aio_complete(iocb, ret, 0);
> -     inode_dio_done(inode);
> +     generic_dio_end_io(iocb, offset, bytes, private, ret, is_async);
>  }
>  
>  /*
> @@ -642,7 +640,7 @@ static ssize_t ocfs2_direct_IO(int rw,
>       return __blockdev_direct_IO(rw, iocb, inode, inode->i_sb->s_bdev,
>                                   iov, offset, nr_segs,
>                                   ocfs2_direct_IO_get_blocks,
> -                                 ocfs2_dio_end_io, NULL, 0);
> +                                 ocfs2_dio_end_io, NULL, DIO_SYNC_WRITES);
>  }
>  
>  static void ocfs2_figure_cluster_boundaries(struct ocfs2_super *osb,
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

"Hell is oneself, hell is alone, the other figures in it, merely projections."
        - T. S. Eliot

                        http://www.jlbec.org/
                        jlbec@xxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>