[Top] [All Lists]

Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 21 Nov 2012 05:12:27 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121115205427.GH14281@dastard>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-6-git-send-email-david@xxxxxxxxxxxxx> <20121115162807.GE4019@xxxxxxxxxxxxx> <20121115205427.GH14281@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 16, 2012 at 07:54:27AM +1100, Dave Chinner wrote:
> Yes, I know, but the original patch I had that changed the ranges to
> something sensible was causing fsx and other failures all over the
> place. It appears that setting the ranges appropriately here exposes
> other (worse) bugs, so I decided to leave doing that until I have
> time to go on a wild goose chase....

I'm actually very happy with doing it separately, I just really prefer
comments to be put in place on why it's done the way it is in case we
forget about it again, which history has shown to happen way too often.

<Prev in Thread] Current Thread [Next in Thread>