xfs
[Top] [All Lists]

[PATCH 4/4][RFC] ocfs2: remove duplicated check from ocfs2_fallocate

To: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Subject: [PATCH 4/4][RFC] ocfs2: remove duplicated check from ocfs2_fallocate
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Tue, 20 Nov 2012 17:29:45 +0800
Cc: yan@xxxxxxxxxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=/2/glSSi7LtDZ0Wm5cWuzwxl+38zMdkQqf35is26knI=; b=rp6mJPyQXUFZ2FQ6DQKp3G/q1oBLRRU7X8KH0i5Xq0Itv/UoZ/euQHXAzp8vKLSMLs Kqc6TJpmbQXBP/EjqBTDdnf9Dz7NQ3c0TNcTyt8Kc/5ANepaBDlau1t/MX85NxJYopZL +Qs0MGH7Vz+b23s7aZxcsx4O6fihMRyOFryvzUk+7GZAORSS1PmDnU9DJDmBYojX99nt Zhu1XzpLxAj3SPMYXezhg/9V7l9Mtf8CuFx44dEpOpZ5SGu/nOvRkoOmeGyy1cxCq89R h6/aAiLgoK5f3omUSIyzPlOITvpkrZ6N7AnywbbYkKkquV0NNQcf/Phrpa9MGomFymhF iXcg==
In-reply-to: <1353403785-3489-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1353403785-3489-1-git-send-email-wenqing.lz@xxxxxxxxxx>
From: Zheng Liu <wenqing.lz@xxxxxxxxxx>

Remove a sanity check from ocfs2_fallocate because vfs has already checked it.

Reported-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
---
 fs/ocfs2/file.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 5a4ee77..2446efa 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2001,8 +2001,6 @@ static long ocfs2_fallocate(struct file *file, int mode, 
loff_t offset,
        int change_size = 1;
        int cmd = OCFS2_IOC_RESVSP64;
 
-       if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
-               return -EOPNOTSUPP;
        if (!ocfs2_writes_unwritten_extents(osb))
                return -EOPNOTSUPP;
 
-- 
1.7.12.rc2.18.g61b472e

<Prev in Thread] Current Thread [Next in Thread>