xfs
[Top] [All Lists]

[PATCH 2/4][RFC] xfs: remove duplicated check from xfs_file_fallocate

To: linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx
Subject: [PATCH 2/4][RFC] xfs: remove duplicated check from xfs_file_fallocate
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Tue, 20 Nov 2012 17:29:43 +0800
Cc: yan@xxxxxxxxxxxxxxxxxx, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=U3p3z+KrRjcHLpn3kNOtbYbrmq1AgzaTUTd9ANfazQ8=; b=Ixo8gnlT8i0AGXRHw+2VvdXC6SkYXaH6TFkWrhD9b8cNueBFF9v0TKjsVWqh5+Aufo ko0AMzuoUmbMTfQni/9fgchPGcsIgbT5u807/TrosBSAiCBovF5Lk3MuORsyxOKMAjID vpG9gcFUlGnwaB+zQ8U/Ps1KUOF4yg0JpjMylB7Fo7KdY4OoBu4jDXM91otUXIyYgWE1 ED49c7+oascmuc7vbqbPSMD4sEbqSIC86E7foQ55rV4/rFGdFPMZdvSiGz31WilmN0Y5 VGp6vgN0nB5YW8imm/6raxvePLTUozyLs5FHZ3djeB1IVUxQQHl3XAjD2GRMHpyIST4l 9yog==
In-reply-to: <1353403785-3489-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1353403785-3489-1-git-send-email-wenqing.lz@xxxxxxxxxx>
From: Zheng Liu <wenqing.lz@xxxxxxxxxx>

Remove a sanity check from xfs_file_fallocate because vfs has already checked
it.

Reported-by: Guo Chao <yan@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
---
 fs/xfs/xfs_file.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index aa473fa..7b50d12 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -815,9 +815,6 @@ xfs_file_fallocate(
        int             cmd = XFS_IOC_RESVSP;
        int             attr_flags = XFS_ATTR_NOLOCK;
 
-       if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE))
-               return -EOPNOTSUPP;
-
        bf.l_whence = 0;
        bf.l_start = offset;
        bf.l_len = len;
-- 
1.7.12.rc2.18.g61b472e

<Prev in Thread] Current Thread [Next in Thread>