xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: correctly initialise the default path

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_quota: correctly initialise the default path
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 19 Nov 2012 21:41:51 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1353028488-24436-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1353028488-24436-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/15/12 19:14, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

+       if (argc != optind)
+               fs_path = fs_table_lookup(argv[optind], FS_MOUNT_POINT);

If specified device is not in the table, then the program will give an error before getting here, so this cannot return a NULL as I previously was concerned about. So this does in fact look good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>