xfs
[Top] [All Lists]

Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 15 Nov 2012 11:55:47 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121114065013.GE1710@dastard>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-18-git-send-email-david@xxxxxxxxxxxxx> <20121114065013.GE1710@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/14/12 00:50, Dave Chinner wrote:
xfs: verify dquot blocks as they are read from disk

From: Dave Chinner<dchinner@xxxxxxxxxx>

Add a dquot buffer verify callback function and pass it into the
buffer read functions. This checks all the dquots in a buffer, but
cannot completely verify the dquot ids are correct. Also, errors
cannot be repaired, so an additional function is added to repair bad
dquots in the buffer if such an error is detected in a context where
repair is allowed.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
Reviewed-by: Phil White<pwhite@xxxxxxx>
---
V2: quotacheck wasn't verifying dquots as they were read from disk


FYI:

The xfs_quota program does not generate output with V2 which causes xfstest 050 to fails.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>