| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 04/32] xfs: remove xfs_flush_pages |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 15 Nov 2012 11:24:17 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1352721264-3700-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 12, 2012 at 10:53:56PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > It is a complex wrapper around VFS functions, but there are VFS > functions that provide exactly the same functionality. Call the VFS > functions directly and remove the unnecessary indirection and > complexity. > > We don't need to care about clearing the XFS_ITRUNCATED flag, as > that is done during .writepages. Hence is cleared by the VFS > writeback path if there is anything to write back during the flush. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages(), Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 05/32] xfs: remove xfs_flushinval_pages, Christoph Hellwig |
| Previous by Thread: | [PATCH 04/32] xfs: remove xfs_flush_pages, Dave Chinner |
| Next by Thread: | [PATCH 08/32] xfs: make growfs initialise the AGFL header, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |