xfs
[Top] [All Lists]

Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 03/32] xfs: remove xfs_wait_on_pages()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 15 Nov 2012 11:23:18 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352721264-3700-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 12, 2012 at 10:53:55PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> It's just a simple wrapper around a VFS function that is only called
> by another function in xfs_fs_subr.c. Remove it and call the VFS
> function directly.

And what we really should do is call filemap_write_and_wait_range,
but that fits into the later patches better (if you haven't done it
already..)

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>