xfs
[Top] [All Lists]

Re: [PATCH 19/32] xfs: factor dir2 block read operations

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 19/32] xfs: factor dir2 block read operations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 15 Nov 2012 16:59:56 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121115030928.GA27055@xxxxxxx>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-20-git-send-email-david@xxxxxxxxxxxxx> <20121115030928.GA27055@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 14, 2012 at 09:09:28PM -0600, Ben Myers wrote:
> On Mon, Nov 12, 2012 at 10:54:11PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > In preparation for verifying dir2 block format buffers, factor
> > the read operations out of the block operations (lookup, addname,
> > getdents) and some of the additional logic to make it easier to
> > understand an dmodify the code.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> This was a difficult review.  I think you have at least three ideas in here
> which could be split up.  Please keep the reviewer in mind.

I do, but it's a trade-off.

If I split every patch upon fine grained "idea" boundaries, I'm
going to generate 5x the number of patches compared to what I'm
already posting.  Massively deep patch stacks that have top to
bottom dependencies (which these patch series have) are a nightmare
to maintain and develop, and I'm already at that limit given the
number of patches I already have on top of this series. If I can't
manage the series, then it doesn't matter whether it's easy to
review or not - the work simply won't get done because I'll be
spending all my time patch monkeying instead of writing and testing
code....

IOWs, I'm making the series as fine grained as possible, but there
are going to be some patches where splitting them up is just
make-work that provides zero gain whilst increasing management
overhead....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>