xfs
[Top] [All Lists]

Re: [PATCH 19/32] xfs: factor dir2 block read operations

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 19/32] xfs: factor dir2 block read operations
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 14 Nov 2012 21:09:28 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352721264-3700-20-git-send-email-david@xxxxxxxxxxxxx>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-20-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 12, 2012 at 10:54:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> In preparation for verifying dir2 block format buffers, factor
> the read operations out of the block operations (lookup, addname,
> getdents) and some of the additional logic to make it easier to
> understand an dmodify the code.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

This was a difficult review.  I think you have at least three ideas in here
which could be split up.  Please keep the reviewer in mind.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>