Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbac

xfs

Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbac

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Wed, 14 Nov 2012 16:23:03 -0600
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20121114065231.GF1710@dastard>
References:	<1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-29-git-send-email-david@xxxxxxxxxxxxx> <20121114065231.GF1710@dastard>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 11/14/12 00:52, Dave Chinner wrote:

xfs: add pre-write metadata buffer verifier callbacks

From: Dave Chinner<dchinner@xxxxxxxxxx>

These verifiers are essentially the same code as the read verifiers,
but do not require ioend processing. Hence factor the read verifier
functions and add a new write verifier wrapper that is used as the
callback.

This is done as one large patch for all verifiers rather than one
patch per verifier as the change is largely mechanical. This
includes hooking up the write verifier via the read verifier
function.

Hooking up the write verifier for buffers obtained via
xfs_trans_get_buf() will be done in a separate patch as that touches
code in many different places rather than just the verifier
functions.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
V2: fold in quotacheck dquot verifier changes.


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, (continued) Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Dave Chinner Re: [PATCH 17/32 V2] xfs: verify dquot blocks as they are read from disk, Dave Chinner [PATCH 26/32] xfs: Add verifiers to dir2 data readahead., Dave Chinner [PATCH 21/32] xfs: factor dir2 free block reading, Dave Chinner [PATCH 24/32] xfs: factor and verify attr leaf reads, Dave Chinner [PATCH 31/32] xfs: add CRC infrastructure, Dave Chinner Re: [PATCH 31/32] xfs: add CRC infrastructure, Mark Tinguely [PATCH 31/32 V2] xfs: add CRC infrastructure, Dave Chinner [PATCH 28/32] xfs: add pre-write metadata buffer verifier callbacks, Dave Chinner [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Dave Chinner Re: [PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Mark Tinguely <= [PATCH 18/32] xfs: add verifier callback to directory read code, Dave Chinner [PATCH 32/32] xfs: add CRC checks to the log, Dave Chinner Re: [PATCH 32/32] xfs: add CRC checks to the log, Mark Tinguely [PATCH 16/32] xfs: verify btree blocks as they are read from disk, Dave Chinner [PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner Re: [PATCH 19/32] xfs: factor dir2 block read operations, Ben Myers Re: [PATCH 19/32] xfs: factor dir2 block read operations, Dave Chinner [PATCH 25/32] xfs: add xfs_da_node verification, Dave Chinner [PATCH 29/32] xfs: connect up write verifiers to new buffers, Dave Chinner [PATCH 29/32 V2] xfs: connect up write verifiers to new buffers, Dave Chinner

Previous by Date:	Re: [PATCH 12/32 V2] xfs: verify AGF blocks as they are read from disk, Mark Tinguely
Next by Date:	Re: [PATCH 19/32] xfs: factor dir2 block read operations, Ben Myers
Previous by Thread:	[PATCH 28/32 V2] xfs: add pre-write metadata buffer verifier callbacks, Dave Chinner
Next by Thread:	[PATCH 18/32] xfs: add verifier callback to directory read code, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]