xfs
[Top] [All Lists]

Re: [patch 2/2 V2] xfstests: xfs_tosspages() test addition

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [patch 2/2 V2] xfstests: xfs_tosspages() test addition
From: Andrew Dahl <adahl@xxxxxxx>
Date: Wed, 14 Nov 2012 12:35:26 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <50A3DC58.4080704@xxxxxxx>
References: <20121108222315.505370321@xxxxxxx> <20121108222315.709683665@xxxxxxx> <20121108232726.GV6434@dastard> <50A19EC0.4040405@xxxxxxx> <50A3DC58.4080704@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2
On 11/14/2012 12:00 PM, Mark Tinguely wrote:
> On 11/12/12 19:13, Andrew Dahl wrote:
>>
>> Tests the XFS_IOC_ZERO_RANGE ioctl by way of the "xfs_io zero" utility
>> to ensure it is tossing the expected ranges.
>>
>> The ranges tested are [0,1] [0,4095] [0,4096] [0,4097] [4095,8191]
>>    [4095,8192] [4095,8193] [4096,8192] [1024,4096]
>>
>> Signed-off-by: Andrew Dahl<adahl@xxxxxxx>
>>
>> ---
>>
> 
> ...
> 
> 
>> +
>> +    $XFS_IO_PROG -F -f -t -c "pwrite -S 0x41 0 4096" \
> 
> -F is deprecated in xfs_io.
> 
> Looks good.
> 
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

Actually... I just realized I neglected to add one change in there. The
call to _require_xfs_io_zero doesn't exist, but should in common.rc

I'll repost the patch with this included.

<Prev in Thread] Current Thread [Next in Thread>