xfs
[Top] [All Lists]

Re: [PATCH 06/32] xfs: use btree block initialisation functions in growf

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 06/32] xfs: use btree block initialisation functions in growfs
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Tue, 13 Nov 2012 15:18:39 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1352721264-3700-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1352721264-3700-1-git-send-email-david@xxxxxxxxxxxxx> <1352721264-3700-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
On 11/12/2012 05:53 AM, Dave Chinner wrote:
From: Dave Chinner <dchinner@xxxxxxxxxx>

Factor xfs_btree_init_block() to be independent of the btree cursor,
and use the function to initialise btree blocks in the growfs code.
This makes adding support for different format btree blocks simple.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_btree.c |   33 ++++++++++++++++++++++++---------
  fs/xfs/xfs_btree.h |   11 +++++++++++
  fs/xfs/xfs_fsops.c |   37 +++++++++++++------------------------
  3 files changed, 48 insertions(+), 33 deletions(-)


Looks good.

Reviewed-by Rich Johnston <rjohnston@xxxxxxx>

--Rich

<Prev in Thread] Current Thread [Next in Thread>