[Top] [All Lists]

Re: [PATCH 0/3] xfs: fixes for 3.7-rc6

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 0/3] xfs: fixes for 3.7-rc6
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 13 Nov 2012 14:05:07 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121113020150.GY9783@xxxxxxx>
References: <1352718586-3538-1-git-send-email-david@xxxxxxxxxxxxx> <20121113020150.GY9783@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 12, 2012 at 08:01:50PM -0600, Ben Myers wrote:
> Hi Dave,
> On Mon, Nov 12, 2012 at 10:09:43PM +1100, Dave Chinner wrote:
> > These are the remaining fixes I have in my tree for the 3.7 cycle.
> > One is a corruption fix, the other two are problems I'm seeing
> > during shutdown and recovery testing. That testing lasts 400-500
> > cycles (3-4 hours) now before it fails with another, as yet unknown
> > buffer/perag reference assert failure. Without these fixes, it lasts
> > 3-4 cycles before assert failing or triggering a BUG.
> > 
> > I'd like these fixes to be in the 3.7 cycle if at all possible, with
> > both patch 1 and 2 being stable kernel candidates.
> I think we can make that happen.  I noticed that you posted patches 2 and 3
> earlier today and had to chuckle, but I understand.

Fixing a nasty bug or regression bug and asking it be merged into
the current -rc cycle after initial testing is not unusual, so I'm
not sure why you'd chuckle at that....

> We'll put this 3.7 work at
> the top of the priority queue, followed by your 3.8 queue, and then the few
> items left for the userspace release.

Just FYI, the first thing that needs to be done after the userspace
release is to resync the libxfs/libxlog code with the kernel code.
That needs to be done before any of the CRC changes can be merged,
so be prepared for a pretty major update that'll need review soon
after the release.

IIRC, the last kernel/user resync I did was about 15,000 lines of
change I don't expect this to be quite as big (the previous one
contained the btree consolidation changes), but I'd expect it to be
in the order of 2-3000 lines of change to be needed.

> Thanks for reposting your 3.8 queue, BTW.  Sometimes I think that frequent
> reposts are inconvenient, but in this case I think it will be helpful.

When I'm having trouble tracking of several of my own patch sets for
the same release, it's time for re-organisation and a repost.
Besides, it's a habit Christoph and I got into a while back when we
had lots of work going on and we needed to make sure nothing
slipped through the cracks..... :)


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>