| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: xfs: Remove boolean_t typedef completely. |
| From: | Thiago Farina <tfransosi@xxxxxxxxx> |
| Date: | Tue, 13 Nov 2012 00:02:14 -0200 |
| Cc: | linux list <linux-kernel@xxxxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=QBBU10lKsh/MnccoCtAjy7/W/cZ2pim/Uyo5wTOaPEY=; b=oXJ27xcEty0UIFd7g526ATdpzpTIQ5TTxn0Hu5blPfJ+T1TkQSE9liYE0koo4qwg3j cKVlqx1bd7RZkSCOAOVqmRbxEttVAGecw+4omua6YQOk8ntOGQxtogogIplwzOorlmpZ hQ/kdQY854PMHphTrEO/ShCJttu5CRYH/oM9FS5DFIH41aS+NgUrMQViHsvEzz7HD95v 6zzLz0X5NsVS58deo5S+NV6hCDHrXl7TSDbXaHfDD4zFAXlx0J2j+3N4SeBWXDAnqJ7k rM3a28Z9mfyfEhVJ4rHbV/M1bJs++hZmqSOz9mJmNeuWl1uWrCBpcKIaGUkEgXt28b5J eXeA== |
| In-reply-to: | <20121113015318.GD25039@dastard> |
| References: | <CACnwZYd2kPaK1urLYc8BBuuqD7_Oo1oF+KvqWYj7DAEGy6grHQ@xxxxxxxxxxxxxx> <20121113015318.GD25039@dastard> |
On Mon, Nov 12, 2012 at 11:53 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Mon, Nov 12, 2012 at 10:36:47PM -0200, Thiago Farina wrote: >> On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: >> > On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: >> >> Hi, >> >> >> >> Please, take a look. >> >> >> >> Patch attached. >> > >> > It's a good start for a cleanup, but there's no point in removing >> > the boolean_t from one file and then not removing it from the rest >> > of the XFS code. It's only used in a handful of places, so just >> > remove it completely. >> > >> Done. >> >> Please, take another look. >> >> > Also, can you please place patches in line rather than attaching >> > them. Attaching them means they cannot be quoted in reply. See >> > Documentation/SubmittingPatches and Documentation/email-clients.txt >> > for guidelines. >> > >> Sorry, patch attached. > > It's still attached as a base64 encoded attachment, not as inline > text.... > Yep, sorry about that. Is just a text file from $(git format-patch master); |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 0/3] xfs: fixes for 3.7-rc6, Ben Myers |
|---|---|
| Next by Date: | Re: xfs: Remove boolean_t typedef completely., Ben Myers |
| Previous by Thread: | Re: xfs: Remove boolean_t typedef completely., Dave Chinner |
| Next by Thread: | Re: xfs: Remove boolean_t typedef completely., Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |