xfs
[Top] [All Lists]

xfs: Remove boolean_t typedef completely.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: xfs: Remove boolean_t typedef completely.
From: Thiago Farina <tfransosi@xxxxxxxxx>
Date: Mon, 12 Nov 2012 22:36:47 -0200
Cc: linux list <linux-kernel@xxxxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=tSkGD/T7eAkOIizLlX4oP1uzyPRI5yyDdi6vN2wf7d8=; b=owNvlkFjQou2oZWvdbD1eyWVWPmAdtQQ+XO/ABWuTN1/wPza07s2wDnQ7ZULuMpeG4 xdsVoWRbgWyiaec979tfGz+cQm9HjlQlStYvt7Ejz+RIzcKdLBF+Ho3We2SbAY+8Rfcb YNfgWYnQalCckMQ8X3fs+2r3HMppdt7LGGXQVBVO9moDt1iuRXoFMkvGYOkSy74v9HA1 GPWcCestADDKWNcJmjaD0KVHycENhX9dNZDcsaQ1yZNkDubnPPeNzTlhnn55LuaJpJsO /niX+nhwEEg6xNREXk8qZzECt31o11leGGij6qDnxmhXhGz0vlkcvyr3CDqXxyZ880B7 OcVg==
On Mon, Nov 12, 2012 at 10:24 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote:
>> Hi,
>>
>> Please, take a look.
>>
>> Patch attached.
>
> It's a good start for a cleanup, but there's no point in removing
> the boolean_t from one file and then not removing it from the rest
> of the XFS code.  It's only used in a handful of places, so just
> remove it completely.
>
Done.

Please, take another look.

> Also, can you please place patches in line rather than attaching
> them. Attaching them means they cannot be quoted in reply. See
> Documentation/SubmittingPatches and Documentation/email-clients.txt
> for guidelines.
>
Sorry, patch attached.

Thanks,

Attachment: 0001-xfs-Remove-boolean_t-typedef-completely.patch
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>