| To: | Thiago Farina <tfransosi@xxxxxxxxx> |
|---|---|
| Subject: | Re: xfs: Use bool type rather than a custom boolean_t type. |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Tue, 13 Nov 2012 11:24:20 +1100 |
| Cc: | linux list <linux-kernel@xxxxxxxxxxxxxxx>, Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <CACnwZYdPntxqWh_Hb2=fa4NPFhtZQSj-sRK3hMHcK6FdctQEXw@xxxxxxxxxxxxxx> |
| References: | <CACnwZYdPntxqWh_Hb2=fa4NPFhtZQSj-sRK3hMHcK6FdctQEXw@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Mon, Nov 12, 2012 at 09:36:17PM -0200, Thiago Farina wrote: > Hi, > > Please, take a look. > > Patch attached. It's a good start for a cleanup, but there's no point in removing the boolean_t from one file and then not removing it from the rest of the XFS code. It's only used in a handful of places, so just remove it completely. Also, can you please place patches in line rather than attaching them. Attaching them means they cannot be quoted in reply. See Documentation/SubmittingPatches and Documentation/email-clients.txt for guidelines. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | xfs: Use bool type rather than a custom boolean_t type., Thiago Farina |
|---|---|
| Next by Date: | [PATCH] xfs: Don't flush inodes when project quota exceeded, Jan Kara |
| Previous by Thread: | xfs: Use bool type rather than a custom boolean_t type., Thiago Farina |
| Next by Thread: | [PATCH] xfs: Don't flush inodes when project quota exceeded, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |