xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfsdump: refuse restore of V4 format unless FS has proji

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfsdump: refuse restore of V4 format unless FS has projid32bit set
From: Rich Johnston <rjohnston@xxxxxxx>
Date: Fri, 9 Nov 2012 12:32:08 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <50788EC3.2060701@xxxxxxxxxxx>
References: <50788C50.40600@xxxxxxxxxx> <50788EC3.2060701@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1
On 10/12/2012 04:42 PM, Eric Sandeen wrote:
Restoring a dump w/ the top 16 bits of a 32-bit project ID
set will fail to restore the full ID unless the projid32 feature
flag is set on the filesystem.

So if the target fs is xfs, fail the restore if we have a version
4 dump (only used currently if dumped from a projid32 fs) and
the target xfs filesystem does not have that feature set.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

p.s. i'd rather go by whether the contents of the dump have any
16 bit project ids than by the feature flag, but I don't see
a way to do that.

diff --git a/restore/content.c b/restore/content.c

Looks good Eric.
Reviewed-by: Rich Johnston <rjohnston@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 3/3] xfsdump: refuse restore of V4 format unless FS has projid32bit set, Rich Johnston <=