xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: get return value in seek_sanity_test

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH v2] xfstests: get return value in seek_sanity_test
From: Zheng Liu <gnehzuil.liu@xxxxxxxxx>
Date: Fri, 9 Nov 2012 11:25:51 +0800
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, Zheng Liu <wenqing.lz@xxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=6gWkto8pdBqeh2VljqP7UNWIj24yBasSV+uAg/WwrNQ=; b=EWfsIhHkzQdI9LQ41BIimmwVcr95aNgfndzgLL61awfOMhb1dpJts1Ik4d5bOMPuge BnP4vXCO8fFJh91RqpZdoXtqJWVHhz1cKaNSj5ZrTzgrxo9c6lXkUIXM5Jki5a85f+Do eW4d5kss9Lelx/fT6P6RwNQfuJuR8A9+mMh2/DL8niB9SXJst/gN09vpV4rqEsZI4yVx jLy4/IkNbgXnJyUHRV43cGHRt1I0c0YjELmJgmHVIWB9oUsfZPLa6n0+3iGeWo1jMKYc uP6BvDjte722PG9hXH53yfQZjegFC1dHnj5WOcK9bZYBmUFB+2p2pShsm6NPH9U7K44n roPw==
In-reply-to: <1350825309-30733-1-git-send-email-wenqing.lz@xxxxxxxxxx>
References: <1350825309-30733-1-git-send-email-wenqing.lz@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sun, Oct 21, 2012 at 09:15:09PM +0800, wenqing.lz wrote:

ping?

Regards,
Zheng

> From: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> 
> In seek_sanity_test getting return value is missing.  Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
> 
> CC: Jeff Liu <jeff.liu@xxxxxxxxxx>
> Signed-off-by: Zheng Liu <wenqing.lz@xxxxxxxxxx>
> ---
> v2 <- v1:
>       * put return value check below the run_test()
> 
> Hi Jeff,
> 
> Could you please review this patch again?  Thanks.
> 
> Regards,
> Zheng
> 
>  src/seek_sanity_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..3897f02 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
>               goto out;
>  
>       for (i = 0; i < numtests; ++i) {
> +             ret = run_test(&seek_tests[i]);
>               if (ret)
> -                     goto out;
> -             run_test(&seek_tests[i]);
> +                     break;
>       }
>  
>  out:
> -- 
> 1.7.12.rc2.18.g61b472e
> 

<Prev in Thread] Current Thread [Next in Thread>