xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: add CRC infrastructure

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: add CRC infrastructure
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Wed, 7 Nov 2012 22:39:46 +0100
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121107203105.GE6434@dastard>
References: <1352295452-4726-1-git-send-email-david@xxxxxxxxxxxxx> <1352295452-4726-2-git-send-email-david@xxxxxxxxxxxxx> <m2ehk5qt88.fsf@xxxxxxxxxxxxxx> <20121107203105.GE6434@dastard>
User-agent: Mutt/1.4.2.2i
> Why would that be necessary? We never include the checksum field in
> the calculation when setting it or verifiying it, and the
> verification uses exactly the same method as the original
> calculation to check the CRC, so it doesn't matter if the CRC value
> is zero or not - if it matches (zero or otherwise), the validation
> passes....

I thought zero meant the checksum is not there? You stated that
somewhere else.

-Andi

<Prev in Thread] Current Thread [Next in Thread>