xfs
[Top] [All Lists]

Re: [PATCH v7 09/10] xfs: add minimum file size filtering to eofblocks s

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v7 09/10] xfs: add minimum file size filtering to eofblocks scan
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 8 Nov 2012 07:33:58 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352308874-64562-3-git-send-email-bfoster@xxxxxxxxxx>
References: <1352213447-59791-1-git-send-email-bfoster@xxxxxxxxxx> <1352308874-64562-1-git-send-email-bfoster@xxxxxxxxxx> <1352308874-64562-3-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 07, 2012 at 12:21:14PM -0500, Brian Foster wrote:
> Support minimum file size filtering in the eofblocks scan. The
> caller must set the XFS_EOF_FLAGS_MINFILESIZE flags bit and minimum
> file size value in bytes.
> 
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
> ---
> 
> v7:
> - Add eof_min_file_size such that it is aligned.
> - Updated flags style.
> 
>  fs/xfs/xfs_fs.h     |    7 +++++--
>  fs/xfs/xfs_icache.c |   11 +++++++++--
>  2 files changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h
> index 7113564..8455c9c 100644
> --- a/fs/xfs/xfs_fs.h
> +++ b/fs/xfs/xfs_fs.h
> @@ -349,7 +349,8 @@ struct xfs_eofblocks {
>       gid_t           eof_gid;
>       prid_t          eof_prid;
>       __u32           pad32;
> -     __u64           pad64[13];
> +     __u64           eof_min_file_size;
> +     __u64           pad64[12];
>  };

Looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>