On Tue, Nov 06, 2012 at 09:55:04AM -0500, Brian Foster wrote:
> This is an update to Dave's patch to xfs_spaceman to support
> preallocation trimming. The original patch is here:
> The code is updated as follows:
> - Update to latest struct xfs_eofblocks (supports v6 of the
> speculative preallocation inode tracking set).
> - Support multiple id scan.
> - Fix the minimum argument count (no args means a trylock scan).
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
> I can also squash this into the original and post a new version if that is
I'll probably do that myself - the current code I have is a little
different so the patch probably won't apply, anyway. I'll need to
munge it to suit the eventual struct xfs_eofblocks format, anyway.
> @@ -136,7 +142,7 @@ prealloc_help(void)
> "Control speculative preallocation\n"
> -"Options: [-s] [-ugp id] [-m minlen]\n"
> +"Options: [-s] [-u id] [-g id] [-p id] [-m minlen]\n"
> " -s -- synchronous flush - wait for flush to complete\n"
> " -u id -- remove prealloc on files matching user quota id <id>\n"
> @@ -153,11 +159,11 @@ prealloc_init(void)
> prealloc_cmd.name = "prealloc";
> prealloc_cmd.altname = "prealloc";
> prealloc_cmd.cfunc = prealloc_f;
> - prealloc_cmd.argmin = 1;
> + prealloc_cmd.argmin = 0;
While technically correct, it's not the desired behaviour. I wanted
it to issue the usage if you just type the comment. I think I need
to add a "-a" flag for "flush all" here.
> - prealloc_cmd.oneline = _("Control specualtive preallocation");
> + prealloc_cmd.oneline = _("Control speculative preallocation");
Good catch, Brain! :)