xfs
[Top] [All Lists]

Re: [PATCH v6 09/10] xfs: add minimum file size filtering to eofblocks s

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v6 09/10] xfs: add minimum file size filtering to eofblocks scan
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 06 Nov 2012 10:57:34 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352213447-59791-10-git-send-email-bfoster@xxxxxxxxxx>
References: <1352213447-59791-1-git-send-email-bfoster@xxxxxxxxxx> <1352213447-59791-10-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/06/12 08:50, Brian Foster wrote:
Support minimum file size filtering in the eofblocks scan. The
caller must set the XFS_EOF_FLAGS_MINFILESIZE flags bit and minimum
file size value in bytes.

Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx>
---
  fs/xfs/xfs_fs.h     |    6 ++++--
  fs/xfs/xfs_icache.c |   11 +++++++++--
  2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_fs.h b/fs/xfs/xfs_fs.h
index 88eb1bc..082b743 100644
--- a/fs/xfs/xfs_fs.h
+++ b/fs/xfs/xfs_fs.h
@@ -348,7 +348,8 @@ struct xfs_eofblocks {
        uid_t           eof_uid;
        gid_t           eof_gid;
        prid_t          eof_prid;
-       __u32           pad[27];
+       __u64           eof_min_file_size;
+       __u32           pad[25]
                            ^^
Glad you bumped it to a unsigned 64 bit value.
Are __u64 items 64 bits? if so, the pad would be 24

  };


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx?

<Prev in Thread] Current Thread [Next in Thread>