xfs
[Top] [All Lists]

Re: [PATCH v6 07/10] xfs: add inode id filtering to eofblocks scan

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v6 07/10] xfs: add inode id filtering to eofblocks scan
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Tue, 06 Nov 2012 10:41:16 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1352213447-59791-8-git-send-email-bfoster@xxxxxxxxxx>
References: <1352213447-59791-1-git-send-email-bfoster@xxxxxxxxxx> <1352213447-59791-8-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/06/12 08:50, Brian Foster wrote:
Support inode ID filtering in the eofblocks scan. The caller must
set the associated XFS_EOF_FLAGS_*ID bit and ID field.

Signed-off-by: Brian Foster<bfoster@xxxxxxxxxx>
---

turn 0;

+       if (eofb&&

                vvvvvvv
+           (eofb->eof_flags&  (XFS_EOF_FLAGS_UID|XFS_EOF_FLAGS_GID|
+                              XFS_EOF_FLAGS_PRID))&&
                ^^^^^^
Not a big deal but wouldn't xfs_inode_match_id() also check these flags?

+           !xfs_inode_match_id(ip, eofb))
+               return 0;
+


Consider this

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>