xfs
[Top] [All Lists]

Re: [PATCH 6/6] xfs: fix reading of wrapped log data

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfs: fix reading of wrapped log data
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 02 Nov 2012 16:24:50 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351816724-3000-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1351816724-3000-1-git-send-email-david@xxxxxxxxxxxxx> <1351816724-3000-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 11/01/12 19:38, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Commit 4439647 ("xfs: reset buffer pointers before freeing them") in
3.0-rc1 introduced a regression when recovering log buffers that
wrapped around the end of log. The second part of the log buffer at
the start of the physical log was being read into the header buffer
rather than the data buffer, and hence recovery was seeing garbage
in the data buffer when it got to the region of the log buffer that
was incorrectly read.

Cc:<stable@xxxxxxxxxxxxxxx>  # 3.0.x, 3.2.x, 3.4.x 3.6.x
Reported-by: Torsten Kaiser<just.for.lkml@xxxxxxxxxxxxxx>
Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>