[Top] [All Lists]

Re: [PATCH 6/6] xfs: fix reading of wrapped log data

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfs: fix reading of wrapped log data
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Nov 2012 09:07:00 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351816724-3000-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1351816724-3000-1-git-send-email-david@xxxxxxxxxxxxx> <1351816724-3000-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 02, 2012 at 11:38:44AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Commit 4439647 ("xfs: reset buffer pointers before freeing them") in
> 3.0-rc1 introduced a regression when recovering log buffers that
> wrapped around the end of log. The second part of the log buffer at
> the start of the physical log was being read into the header buffer
> rather than the data buffer, and hence recovery was seeing garbage
> in the data buffer when it got to the region of the log buffer that
> was incorrectly read.

I think you mentioned earlier you found a reproducer for this, any
chance it could be added to xfstests?

>                               error = xlog_bread_offset(log, 0,
> -                                             bblks - split_bblks, hbp,
> +                                             bblks - split_bblks, dbp,

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>