xfs
[Top] [All Lists]

Re: [PATCH 1/6] xfs: silence uninitialised f.file warning.

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfs: silence uninitialised f.file warning.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 2 Nov 2012 09:04:43 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1351816724-3000-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1351816724-3000-1-git-send-email-david@xxxxxxxxxxxxx> <1351816724-3000-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Nov 02, 2012 at 11:38:39AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Uninitialised variable build warning introduced by 2903ff0 ("switch
> simple cases of fget_light to fdget"), gcc is not smart enough to
> work out that the variable is not used uninitialised, and the commit
> removed the initialisation at declaration that the old variable had.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>