xfs
[Top] [All Lists]

Re: [PATCH] xfsdump:fill in bs_forkoff

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] xfsdump:fill in bs_forkoff
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 01 Nov 2012 23:35:54 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx>
In-reply-to: <20121031194654.GB9783@xxxxxxx>
References: <5080D0BD.3000304@xxxxxxxxxx> <20121030194718.GD405@xxxxxxx> <50903075.6060600@xxxxxxxxxx> <20121031194654.GB9783@xxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20121026 Thunderbird/16.0.2
On 10/31/12 2:46 PM, Ben Myers wrote:
> Hi Eric,

...

> It seemed like it could be an important bugfix but I wasn't really sure so I
> asked.  Since it sounds like it's not a big deal, lets just hold off till 
> after
> the release...

Well, I was wrong - at least at one point, I thought it was getting zeroed. (?!)

But Dave was running into trouble tonight ...

And as the git tree stands today, I'm getting checksum errors w/o this patch
too, and xfstests dump group is passing only with it added back in.

So I think you'd better pull it in, maybe change the commit message a bit
though - it downplays the importance too much I guess.

Sorry about that,

-Eric

<Prev in Thread] Current Thread [Next in Thread>