xfs
[Top] [All Lists]

Re: [patch 1/4] xfstests: update version and changelog

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [patch 1/4] xfstests: update version and changelog
From: Ben Myers <bpm@xxxxxxx>
Date: Thu, 1 Nov 2012 11:20:16 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1066591451.20029469.1351717231452.JavaMail.root@xxxxxxxxxx>
References: <20121031192545.662795881@xxxxxxx> <1066591451.20029469.1351717231452.JavaMail.root@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Nathan,

On Wed, Oct 31, 2012 at 05:00:31PM -0400, Nathan Scott wrote:
> They all look good to me, thanks Ben.  One minor thought,
> for future updates...
> 
> ----- Original Message -----
> > ...
> > Index: b/VERSION
> > ===================================================================
> > --- a/VERSION       2012-10-31 13:44:44.931946786 -0500
> > +++ b/VERSION       2012-10-31 13:44:50.832006406 -0500
> > @@ -3,5 +3,5 @@
> >  #
> >  PKG_MAJOR=1
> >  PKG_MINOR=1
> > -PKG_REVISION=0
> > +PKG_REVISION=1
> >  PKG_BUILD=1
> > Index: b/configure.ac
> > ===================================================================
> > --- a/configure.ac  2012-10-31 13:45:41.661946816 -0500
> > +++ b/configure.ac  2012-10-31 13:45:48.072005921 -0500
> > @@ -1,4 +1,4 @@
> > -AC_INIT([xfstests], [1.1.0])
> > +AC_INIT([xfstests], [1.1.1])
> >  AC_PREREQ(2.50)
> >  AC_CONFIG_SRCDIR([src/xfsctl.c])
> >  AC_PACKAGE_GLOBALS(xfstests)
> 
> I wonder if generating the VERSION file from configure makes
> sense, since we are duplicating that info nowadays?

I think it's a good idea.  There are a few other deps on PKG_* so maybe it
would be better to just have configure.ac use PKG* instead of hard coding the
version there.

> Oh, feel free to add Reviewed-by me for all of these patches,
> if you like.

Cool, thanks!

Regards,
        Ben

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [patch 1/4] xfstests: update version and changelog, Ben Myers <=