xfs
[Top] [All Lists]

Re: [patch 1/4] xfstests: update version and changelog

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [patch 1/4] xfstests: update version and changelog
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 31 Oct 2012 17:00:31 -0400 (EDT)
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121031192545.662795881@xxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
They all look good to me, thanks Ben.  One minor thought,
for future updates...

----- Original Message -----
> ...
> Index: b/VERSION
> ===================================================================
> --- a/VERSION 2012-10-31 13:44:44.931946786 -0500
> +++ b/VERSION 2012-10-31 13:44:50.832006406 -0500
> @@ -3,5 +3,5 @@
>  #
>  PKG_MAJOR=1
>  PKG_MINOR=1
> -PKG_REVISION=0
> +PKG_REVISION=1
>  PKG_BUILD=1
> Index: b/configure.ac
> ===================================================================
> --- a/configure.ac    2012-10-31 13:45:41.661946816 -0500
> +++ b/configure.ac    2012-10-31 13:45:48.072005921 -0500
> @@ -1,4 +1,4 @@
> -AC_INIT([xfstests], [1.1.0])
> +AC_INIT([xfstests], [1.1.1])
>  AC_PREREQ(2.50)
>  AC_CONFIG_SRCDIR([src/xfsctl.c])
>  AC_PACKAGE_GLOBALS(xfstests)

I wonder if generating the VERSION file from configure makes
sense, since we are duplicating that info nowadays?

Oh, feel free to add Reviewed-by me for all of these patches,
if you like.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>