xfs
[Top] [All Lists]

Re: [patch 0/2] dmapi: build system revamp

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 0/2] dmapi: build system revamp
From: Ben Myers <bpm@xxxxxxx>
Date: Wed, 31 Oct 2012 08:59:02 -0500
Cc: Jan Engelhardt <jengelh@xxxxxxx>, Rich Johnston <rjohnston@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20121031102153.GA1111@xxxxxxxxxxxxx>
References: <20121030210152.751573876@xxxxxxx> <20121031102153.GA1111@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Christoph,

On Wed, Oct 31, 2012 at 06:21:53AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 30, 2012 at 04:01:52PM -0500, Ben Myers wrote:
> > Hi,
> > 
> > Here are Jan Engelhardt's patches originally posted here
> > http://oss.sgi.com/archives/xfs/2012-05/msg00323.html
> > as they apply to dmapi.  
> > 
> > Patch 2 applied without much modification, patch 3 was not necessary for 
> > dmapi,
> > and patch 6 did not apply at all so I implemented that.
> 
> All the patches in this and the related series look good to me.
> but can you please remove the [PATCH N/N] already in the quilt series?
> 
> Right now we have one [patch n/n] generated by quilt and then another
> mismatching one, which I think would even land in the git commit log.

Aha.  I will clean up the extra [patch n/n].  I didn't expect it would do that.

> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks for the review!

-Ben

<Prev in Thread] Current Thread [Next in Thread>