[Top] [All Lists]

Re: [patch 0/2] dmapi: build system revamp

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [patch 0/2] dmapi: build system revamp
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 31 Oct 2012 06:21:53 -0400
Cc: xfs@xxxxxxxxxxx, Jan Engelhardt <jengelh@xxxxxxx>, Rich Johnston <rjohnston@xxxxxxx>
In-reply-to: <20121030210152.751573876@xxxxxxx>
References: <20121030210152.751573876@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 30, 2012 at 04:01:52PM -0500, Ben Myers wrote:
> Hi,
> Here are Jan Engelhardt's patches originally posted here
> http://oss.sgi.com/archives/xfs/2012-05/msg00323.html
> as they apply to dmapi.  
> Patch 2 applied without much modification, patch 3 was not necessary for 
> dmapi,
> and patch 6 did not apply at all so I implemented that.

All the patches in this and the related series look good to me.
but can you please remove the [PATCH N/N] already in the quilt series?

Right now we have one [patch n/n] generated by quilt and then another
mismatching one, which I think would even land in the git commit log.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>