xfs
[Top] [All Lists]

Re: [PATCH 21/25] xfs: add buffer pre-write callback

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/25] xfs: add buffer pre-write callback
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 31 Oct 2012 06:20:25 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121030223015.GE29378@dastard>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-22-git-send-email-david@xxxxxxxxxxxxx> <20121026085014.GC3035@xxxxxxxxxxxxx> <20121030223015.GE29378@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 31, 2012 at 09:30:15AM +1100, Dave Chinner wrote:
> Perhaps. I just wrote it in a manner consistent with the iodone
> function where errors are returned in bp->b_error. Other functions
> pass buffer errors like this, too - xfs_buf_ioapply_map(),
> xfs_buf_read_map(), and _xfs_buf_ioapply() - so it's not unusual,
> really..
> 
> I can change it, but that involves changing every callback function
> as well and I don't see that as really necessary. i.e. they call
> xfs_buf_ioerror() already, so do we really need to have them return
> bp->b_error as well?

Let's keep it as is for now to make forward progress, we can still
figure out later if doing it differently is cleaner.

<Prev in Thread] Current Thread [Next in Thread>