xfs
[Top] [All Lists]

Re: [PATCH 25/25] xfs: add write verifiers to log recovery

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 25/25] xfs: add write verifiers to log recovery
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 31 Oct 2012 06:19:37 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121030220855.GA29378@dastard>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-26-git-send-email-david@xxxxxxxxxxxxx> <20121026085448.GD3035@xxxxxxxxxxxxx> <20121026203107.GJ29378@dastard> <20121030122331.GB30039@xxxxxxxxxxxxx> <20121030220855.GA29378@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 31, 2012 at 09:08:55AM +1100, Dave Chinner wrote:
> I couldn't find any short of magic number matches. The ones that can
> be inferred (inode and dquot buffers) are done that way, but for
> everything else they are anonymous buffers being recovered. I might
> just drop this patch for now, and only re-introduce it for CRC
> enabled filesystems when that is added.

I fear that's the only reasonable way to go.  Otoh we were planning
to bump the log version at some point anyway, at which point we could
enable the new log formats even without CRCs.

<Prev in Thread] Current Thread [Next in Thread>