xfs
[Top] [All Lists]

Re: [PATCH 1/3] Add new standard loop handling functions

To: Tomas Racek <tracek@xxxxxxxxxx>
Subject: Re: [PATCH 1/3] Add new standard loop handling functions
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 31 Oct 2012 07:40:38 +1100
Cc: xfs@xxxxxxxxxxx, lczerner@xxxxxxxxxx
In-reply-to: <1350549946-17192-1-git-send-email-tracek@xxxxxxxxxx>
References: <1350549946-17192-1-git-send-email-tracek@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 18, 2012 at 10:45:44AM +0200, Tomas Racek wrote:
> Add _create_loop_device and _destroy_loop_device to uniformly handle
> loopback devices.
> 
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>
> ---
>  common.rc | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/common.rc b/common.rc
> index 966fc93..b5edd22 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -1804,6 +1804,21 @@ _test_batched_discard()
>       $FSTRIM_PROG ${1} &>/dev/null
>  }
>  
> +_create_loop_device()
> +{
> +     file=$1
> +     dev=`losetup -f`
> +     losetup $dev $file || _fail "Cannot associate $file with $dev"
> +     echo $dev
> +}
> +
> +_destroy_loop_device()
> +{
> +     dev=$1
> +     losetup -d $dev || _fail "Cannot destroy loop device $dev"
> +}
> +
> +
>  
> ################################################################################

Perhaps a followup patch that converts existing loop device users to
use this interface is appropriate?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>