xfs
[Top] [All Lists]

Re: [PATCH] xfsdump:fill in bs_forkoff

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfsdump:fill in bs_forkoff
From: Ben Myers <bpm@xxxxxxx>
Date: Tue, 30 Oct 2012 14:47:18 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <5080D0BD.3000304@xxxxxxxxxx>
References: <5080D0BD.3000304@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Eric,

On Thu, Oct 18, 2012 at 11:02:05PM -0500, Eric Sandeen wrote:
> Upstream, the structure containing bs_forkoff is actually zeroed
> prior to these functions, but when pulling the patch back to an
> older xfsdump, we got checksum errors due to an uninitialized
> bs_forkoff not matching in dump vs. restore.
> 
> So even though forkoff won't be explicitly restored from
> a dump, do explicitly set it in these routines to keep checksums
> happy.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Would you say that this is appropriate for the upcoming release?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>