[Top] [All Lists]

Re: [PATCH 03/25] xfs: make buffer read verication an IO completion func

To: Phil White <pwhite@xxxxxxx>
Subject: Re: [PATCH 03/25] xfs: make buffer read verication an IO completion function
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2012 11:45:46 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20121030002916.GE30227@xxxxxxxxxxxxxxxxxxxx>
References: <1351146854-19343-1-git-send-email-david@xxxxxxxxxxxxx> <1351146854-19343-4-git-send-email-david@xxxxxxxxxxxxx> <20121030002916.GE30227@xxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 29, 2012 at 05:29:17PM -0700, Phil White wrote:
> On Thu, Oct 25, 2012 at 05:33:52PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Add a verifier function callback capability to the buffer read
> > interfaces.  This will be used by the callers to supply a function
> > that verifies the contents of the buffer when it is read from disk.
> > This patch does not provide callback functions, but simply modifies
> > the interfaces to allow them to be called.
> > 
> > The reason for adding this to the read interfaces is that it is very
> > difficult to tell fom the outside is a buffer was just read from
> > disk or whether we just pulled it out of cache. Supplying a callbck
> > allows the buffer cache to use it's internal knowledge of the buffer
> > to execute it only when the buffer is read from disk.
> > 
> > It is intended that the verifier functions will mark the buffer with
> > an EFSCORRUPTED error when verification fails. This allows the
> > reading context to distinguish a verification error from an IO
> > error, and potentially take further actions on the buffer (e.g.
> > attempt repair) based on the error reported.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> This is OK with me so far, but I have comments on some of the callbacks.

/me looks around, doesn't find anything...

The comments must be elsewhere. ;)

BTW, Phil, can you trim away all the bits of the patch you aren't
commenting on? Having to scroll through hundreds of lines of quoted
email to find your replies is a little slow, and it's quite easy to
miss comments when they are widely spread apart. Most people just
quote the patch hunk they are making the comment about to avoid this


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>